Add missing type declarations for top-level files in src/openfermion#1300
Open
mhucka wants to merge 3 commits into
Open
Add missing type declarations for top-level files in src/openfermion#1300mhucka wants to merge 3 commits into
src/openfermion#1300mhucka wants to merge 3 commits into
Conversation
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds type hints to _compat.py, _compat_test.py, and conftest.py to enhance static type checking. The changes include specifying return types for functions and methods, adding parameter types, and including type ignore comments for dynamic attribute assignments in tests. Additionally, an unused import was removed from the test suite. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more type hints to the Python files at the top level of
src/openfermion.This partly addresses #1282.